NOISSUE - Add Protobuf generated files check #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dborovcanin
force-pushed
the
check-proto-gen
branch
5 times, most recently
from
dcd1028
to
c363986
Compare
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
dborovcanin
force-pushed
the
check-proto-gen
branch
from
c363986
to
7827067
Compare
Codecov Report
@@ Coverage Diff @@
## master #601 +/- ##
=======================================
Coverage 87.11% 87.11%
=======================================
Files 62 62
Lines 3391 3391
=======================================
Hits 2954 2954
Misses 298 298
Partials 139 139Continue to review full report at Codecov.
|
nmarcetic
approved these changes
Feb 17, 2019
dborovcanin
added a commit
to dborovcanin/magistrala
that referenced
this pull request
Mar 4, 2019
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
davide83
pushed a commit
to davide83/mainflux
that referenced
this pull request
May 13, 2019
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
manuio
pushed a commit
that referenced
this pull request
Oct 12, 2020
Signed-off-by: Dusan Borovcanin <dusan.borovcanin@mainflux.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR adds check if Protobuf generated files are in sync with the corresponding
.protofiles.Which issue(s) does this PR fix/relate to?
None.
List any changes that modify/break current functionality
There are no such changes.
Have you included tests for your changes?
No, because there are no code changes in this PR.
Did you document any new/modified functionality?
No, because this is just a CI script update.